x86: remove BUG_ON() from QUIRK_IOAPIC_*_REGSEL handler
authorKeir Fraser <keir@xen.org>
Tue, 7 Dec 2010 18:32:04 +0000 (18:32 +0000)
committerKeir Fraser <keir@xen.org>
Tue, 7 Dec 2010 18:32:04 +0000 (18:32 +0000)
commitca2570b805c06fa70a3fdc3492bf0ef04060c349
treebcb941e47dc184d557e1df8474f64e62221992a7
parent80d4ed4bb9f90025c2e4c7fb941621fee2ef09a4
x86: remove BUG_ON() from QUIRK_IOAPIC_*_REGSEL handler

Since (non-pvops, 32-bit only up to 2.6.27) Linux would report "BAD"
unconditionally on all SiS chipset versions (it only looks for a PCI
device at 0000:00:00.0 with SiS as the vendor), we must not crash if
the report on a 64-bit hypervisor doesn't match the #define (which is
zero).

While we could honor the quirk indication even on 64-bit, it doesn't
seem worthwhile, as there's no evidence that newer SiS chipsets
(supporting 64-bit CPUs) are actually affected.

This should also address bug 1687 (mis-reported, however, afaict).

Signed-off-by: Jan Beulich <jbeulich@novell.com>
xen/arch/x86/platform_hypercall.c